(BREAKING) remove ResultExt and macro_result!() #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
abonander force-pushed the ab/macro-refresh branch 2 times, most recently from bbbe649 to 10d0b4f Compare 
abonander force-pushed the ab/macro-refresh branch 2 times, most recently from 198f89d to c7fa4e6 Compare Signed-off-by: Austin Bonander <austin@launchbadge.com>
abonander force-pushed the ab/macro-refresh branch from c7fa4e6 to 67ad434 Compare abonander changed the title for arguments Signed-off-by: Austin Bonander <austin@launchbadge.com>
Signed-off-by: Austin Bonander <austin@launchbadge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also tries to address supernumerary references in parameters, although it's probably not possible to fix the situation entirely (e.g. we'd need additional impls of
MatchBorrowExtforMatchBorrow<&&T, T>,MatchBorrow<&&&T, T>, etc).Breaking change:
query_as!()and friends will no longer tolerate the difference betweenTandOption<T>in output structs; explicit overrides in the SQL must be used instead.fixes #546
TODO: