[12.x] always use the operator argument for version_compare() #57569
+5 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`version_compare()` can be called without a 3rd argument, and return a -1|0|1, or with a 3rd argument and return a boolean. we currently use this function 28 times in the framework: - 23 with the 3rd argument - 5 without the 3rd argument this commit standardizes our calls to ***always*** use the 3rd argument and return a boolean, which has a couple benefits: - consistency - slight readability improvement rather than magic numbers (subjective I guess) - defensive against operator precedence issues https://www.php.net/manual/en/function.version-compare.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
version_compare()can be called without a 3rd argument, and return a -1|0|1, or with a 3rd argument and return a boolean. we currently use this function 28 times in the framework:this commit standardizes our calls to always use the 3rd argument and return a boolean, which has a couple benefits:
https://www.php.net/manual/en/function.version-compare.php