Skip to content

Conversation

@simon-tma
Copy link
Contributor

Illuminate\Http\Client\Batch works with Illuminate\Http\Client\Response instances. These are not subclasses of Illuminate\Http\Response, so following the types in the comments would result in code that fails when run.

@rodrigopedra
Copy link
Contributor

Can we also take the opportunity to remove the @return void from the constructor's docblock?

/**
* Create a new request batch instance.
*
* @return void
*/
public function __construct(?Factory $factory = null)
{
$this->factory = $factory ?: new Factory;
$this->handler = Utils::chooseHandler();
$this->createdAt = new CarbonImmutable;
}

Those were removed framework-wise here: #55076

@taylorotwell taylorotwell merged commit 6639cc1 into laravel:12.x Oct 22, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants