[12.x] Fix email rule helper message #57323
   Merged  
   Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
When using the
Rule::emailhelper, if you validate a non-string you end up with the class name as the validation message since no messages get set in the rule. I did see the test was expecting that, but without a mention in the docs of needingEmail::class => '...',in your validation file to use the helper I assumed it was unintentional (or there used to be something converting the class string that was lost).Since the email validator it falls back to will fail on a non-string anyway I removed the check and let it get replaced with the invalid validation message.