Skip to content

Conversation

@faisuc
Copy link
Contributor

@faisuc faisuc commented Oct 8, 2025

This fixes frontend breakage on the exception renderer by escaping tooltip content and converting newlines to <br>. It applies to queries, formatted source, request headers, and routing values, preventing layout overlap and syntax highlighter glitches when tooltip content contains newlines. Fixes #57246.

No breaking changes. This affects only the debug exception renderer UI and does not change any APIs.

@taylorotwell taylorotwell requested a review from avosalmon October 8, 2025 20:53
@taylorotwell taylorotwell marked this pull request as draft October 8, 2025 20:53
@crynobone
Copy link
Member

Fixed failling tests

@avosalmon
Copy link
Contributor

This PR wouldn't fix #57246. The tooltip is not causing the issue, but text truncation is broken on syntax-highlighted queries. I opened a PR to fix text truncation. #57315

Having said that, I think it's still nice to render newlines in the tooltip.

@avosalmon avosalmon changed the title Fix/exceptions renderer tooltip newlines escape [12.x] Render newlines in query tooltip Oct 9, 2025
@faisuc faisuc marked this pull request as ready for review October 16, 2025 03:52
@taylorotwell taylorotwell merged commit fecda76 into laravel:12.x Oct 16, 2025
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants