Skip to content

[12.x] fix: Collection::transform() and Paginator::through() return types #56273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

[12.x] fix: Collection::transform() and Paginator::through() return types #56273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Illuminate/Collections/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,7 +1732,9 @@ public function takeWhile($value)
* @template TMapValue
*
* @param callable(TValue, TKey): TMapValue $callback
* @return $this<TKey, TMapValue>
* @return $this
*
* @phpstan-this-out static<TKey, TMapValue>
*/
public function transform(callable $callback)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Pagination/AbstractCursorPaginator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ public function items()
* @template TThroughValue
*
* @param callable(TValue, TKey): TThroughValue $callback
* @return $this<TKey, TThroughValue>
* @return $this
*
* @phpstan-this-out static<TKey, TThroughValue>
*/
Expand Down
4 changes: 3 additions & 1 deletion src/Illuminate/Pagination/AbstractPaginator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,9 @@ public function lastItem()
* @template TMapValue
*
* @param callable(TValue, TKey): TMapValue $callback
* @return $this<TKey, TMapValue>
* @return $this
*
* @phpstan-this-out static<TKey, TMapValue>
*/
public function through(callable $callback)
{
Expand Down
12 changes: 6 additions & 6 deletions types/Support/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,18 +1049,18 @@ function ($collection, $count) {
assertType('Illuminate\Support\Collection<int, User>', $collection->splice(1));
assertType('Illuminate\Support\Collection<int, User>', $collection->splice(1, 1, [new User]));

assertType('mixed', $collection->transform(function ($user, $int) {
assertType('Illuminate\Support\Collection<int, int>', $collection->transform(function ($user, $int): int {
assertType('User', $user);
assertType('int', $int);

return new User;
return $int * 2;
}));

assertType('mixed', $collection->transform(function ($user, $int): int {
assertType('User', $user);
assertType('int', $int);
assertType('Illuminate\Support\Collection<int, User>', $collection->transform(function ($value, $key) {
assertType('int', $value);
assertType('int', $key);

return $int * 2;
return new User;
}));

assertType('Illuminate\Support\Collection<int, User>', $collection->add(new User));
Expand Down