Change return types of through (pagination) and transform (collection)

[glamorous]

The two docblocks where not correct or not enough for typehinting and static analysis (phpstan).

This piece of code (which is working) had a false static analysis:

 /** * @return LengthAwarePaginator<int, PriceResource> */ protected function getPrices(Article $article): LengthAwarePaginator { return $article->prices() ->paginate(10) ->through(fn(Price $price) => PriceResource::make($price)); } 

It was complaining that it wanted a Price instead of PriceResource, but the paginator can change the items their types (it uses the transform in the background).

These fixes in de docblocks make it possible to write this code and pass the static analysis without to use ignore statements.

If some extra files needed an update or a change should be made, feel free to guide me in the right direction. It's up for discussion.

The issue #46487 already mentioned the problem in the past.

[glamorous]

Thanks!

[calebdw]

This change should have been an indicator that something was wrong---phpstan should be perfectly capable of determining the correct generics

[calebdw]

Both of these methods are incorrect:

• $this<...> is a syntax error
• need to use @phpstan-this-out for methods that mutate $this
• see: https://phpstan.org/r/5c9eb5c7-7570-4131-ac77-46d662ab74a6

Here is what they should be:

Suggested change

	* @param callable(TValue, TKey): TMapValue $callback
	* @return $this<TKey, TMapValue>
	* @param callable(TValue, TKey): TMapValue $callback
	* @phpstan-this-out static<TKey, TMapValue>
	* @return $this

[glamorous]

Thanks for the clarification @calebdw ! Didn't know about @phpstan-this-out