Fix attribute name used on Validator instance within certain rule classes #54845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
shaedrich reviewed Feb 28, 2025
crynobone changed the title Validator instance within File rule classValidator instance within certain rule classes 
crynobone added a commit that referenced this pull request Mar 8, 2025
… rule classes Backport PR #54845 to Laravel 10 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
| @crynobone @taylorotwell can this security issue be fixed ALSO in Laravel 8, 9 and 10? Update |
| Also @crynobone the return type is wrong here: /** * Replace each field parameter dot placeholder with dot. * * @param string $value * @return string // should be array */ protected function replaceDotPlaceholderInParameters(array $parameters) { return array_map(function ($field) { return str_replace('__dot__'.static::$placeholderHash, '.', $field); }, $parameters); } |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.