[11.x] Reintroduce ::class Constants for Framework Controllers in Router (Reimplements #54134) #54189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SanderMuller commented Jan 14, 2025
| * @param \Illuminate\Routing\Route $route | ||
| * @return bool | ||
| */ | ||
| protected function isFrameworkController(Route $route) |
There was a problem hiding this comment.
We could probably drop this method and just use $this->router->isFrameworkController((string) $route->getControllerClass()) directly, but I didn't want to introduce this potential breaking change since it's a protected method in a non final class
| I'm not sure what we're actually solving for here. I think it's fine. 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR reimplements #54134, which was reverted in #54185 due to a breaking change. A regression test has since been added, ensuring the change can be safely reintroduced.
Key Changes:
::classconstants for better type safety and maintainability.isFrameworkController()andgetFrameworkControllers()methods to centralize framework controller handling.prependGroupNamespace()to respect framework controllers and avoid unnecessary namespace prefixing.This reimplementation leverages the regression test to address previous concerns while improving code consistency and developer experience.