[9.x] Prompt to create MySQL db when migrating #44153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @timacdonald what happens when the user does not have permissions to create additional databases? |
fgaroby reviewed Sep 16, 2022
| if ( | ||
| $e->getPrevious() instanceof PDOException && | ||
| $e->getPrevious()->getCode() === 1049 && | ||
| $connection->getDriverName() === 'mysql') { |
There was a problem hiding this comment.
Why don't you create a MySQLDatabaseDoesNotExistException, instead of this if with three conditions (like SQLiteDatabaseDoesNotExistException on L.140)?
| If any failure occurs the original exception message would be shown. |
| when i was moving from rails to learn laravel I was missing this suggestion ... thanks so much for adding it ❤️ |
| It's finally come true, I love that, thanks laravels |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is the MySQL counterpart to #43867