Skip to content

[9.x] Adds "PendingCommand::assertOk()" #43968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

[9.x] Adds "PendingCommand::assertOk()" #43968

merged 1 commit into from
Sep 1, 2022

Conversation

@nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Sep 1, 2022 •
edited
Loading

While creating tests for Artisan commands, I've noticed that assertSuccessful is just too many characters for me. So, this pull request proposes an assertOk() method that is simply an alias of assertExitCode(0):

it('can run', function () { $this->artisan('inspire')->assertOk(); });

Note that, this combines well with the HTTP layer regarding testing, as we we already have an assertOk() there:

$this->get('/')->assertOk();
@taylorotwell taylorotwell merged commit 3b6c7ad into 9.x Sep 1, 2022
@taylorotwell taylorotwell deleted the feat/artisan-assert-ok branch September 1, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@nunomaduro @taylorotwell