[12.x] update newCollection override to account for automatic eager loading #10737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
due to the new "automatic eager loading" feature, and the changes made here: laravel/framework@5548f95 the programmer needs to also include these changes when using the `newCollection()` method override for a custom collection, if they want the automatic eager loading feature to work correctly.
Contributor
| Do we need to perform this check every time we create a custom collection using the |
browner12 deleted the AB-custom-collections-with-automatic-lazy-loading branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
due to the new "automatic eager loading" feature, and the changes made here:
laravel/framework@5548f95
the programmer needs to also include these changes when using the
newCollection()method override for a custom collection, if they want the automatic eager loading feature to work correctly.as much as I hate to say it, it might be time to remove the documentation for the
newCollection()method override option, and instead just document the Attribute option.