[12.x] use multiline parameters for casting methods #10345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I find the side scrolling for code snippets to decrease readability. these lengthy method signatures are often the culprit on this page. switching to multiline parameters to help avoid the necessity to side scroll. followed the PSR-12 recommendation for when dealing with multiline parameters AND a return type.
Contributor
Where do you need side-scrolling? On the phone? It's not like these examples are overly long oO
I'd say, that's the actual cause. With your PR you're merely attempting to fix the symptom, which wouldn't be one if the root cause was fixed. |
Contributor Author
| On desktop. You can find an example of side-scrolling on basically every page. |
Contributor
I agree with you, these changes will not solve the problem.
Why it is set to private? and why also the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I find the side scrolling for code snippets to decrease readability. these lengthy method signatures are often the culprit on this page. switching to multiline parameters to help avoid the necessity to side scroll.
followed the PSR-12 recommendation for when dealing with multiline parameters AND a return type.
I know this will be a constant battle in the documentation, and while changes like this won't completely eliminate the problem, I do think they help.
I would also like to see the Laravel documentation site make better use of the space it has available. On larger screens we have the ability to increase the container size. I would also suggest there is a lot of unused space between the columns of our 3 column layout. Changes here would also go a long way to help remove the need for side scrolling. Since the
laravel.comrepo has been set to private, I don't believe the community has the ability to make these suggestions anymore.