update console stub return types and docblocks #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- add `void` return type - remove unnecessary docblocks syncs with a [docs change](laravel-zero/docs@c402dd2)
owenvoke requested changes Jan 17, 2024
There was a problem hiding this comment.
I was thinking of merging this, however I remembered the issues which people brought up when Laravel added return types to these stubs.
Related, I do think we should update the stubs within Laravel Zero to use the {{ class }} format that Laravel uses (rather than DummyClass, etc.)
remove return type Co-authored-by: Owen Voke <development@voke.dev>
| should we also update the "DummyNameSpace"? |
| Yes, and the signature. 👍🏻 Basically like the core |
- use "namespace" and "command" variables rather than "Dummy" string replacement - update docblock descriptions to match `laravel/framework` changes
| okay, everything should be synced up now. I tried this stub on a local Laravel Zero app I have and the file generated correctly. Should be good to review. |
owenvoke approved these changes Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
voidreturn typesyncs with a docs change