Skip to content

Conversation

@m-messer
Copy link
Member

@m-messer m-messer commented Aug 27, 2025

Address GH-221

Copy link
Contributor

@peterbjohnson peterbjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of comments inline. One about making the example clearer, and another about confusing two issues - reserved symbols, and higher-precedence implicit multiplication.

@m-messer
Copy link
Member Author

m-messer commented Sep 5, 2025

@peterbjohnson, I have validated the issue with multiple character input. See #221 for more details. I suggest we update the docs to state this limitation and add another issue to fix the bug.

@m-messer m-messer requested a review from peterbjohnson October 2, 2025 10:18
@m-messer
Copy link
Member Author

m-messer commented Oct 2, 2025

Added a note in the docs about the bug. Once fixed, this note will be removed, and an example of custom multi-character symbols and implicit multiplication will be added.

Copy link
Contributor

@peterbjohnson peterbjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to my comments being addressed

@m-messer m-messer merged commit b4312c6 into main Dec 3, 2025
@m-messer m-messer deleted the docs/GH-221-Format-and-Hack branch December 3, 2025 10:51
@m-messer m-messer restored the docs/GH-221-Format-and-Hack branch December 3, 2025 11:03
m-messer added a commit that referenced this pull request Dec 3, 2025
* Restructured content and added the workaround for reserved terms. * GH-221 Actioned Peter's comments in #222. * GH-221 Refactored README to separate implicit multiplication * Added note about #223 in the docs * Actioned comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants