Tr124 restructuring #214
Merged
Tr124 restructuring #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Still needs: - General cleanup - Many redundant files and redundant code - Various code style issues - Make naming of files more consistent - Move plus_minus handling into expression preprocessing - Review of preview functionality (currently very ad-hoc) - Update docker-file etc before deployment
…gs found along the way
It seems that the sorting of substitutions when replacing input symbols and protecting elementary functions names when using implicit multiplication was not consistent from run to run. Hopefully this is now fixed with an adjusted sorting key, essentially we now first sort based on length of string to substitute (maximum munch) and then on the length of the replacement. Previously only the length of the string to be substituted was taken into consideration. The new key does not guarantee a unique ordering in all cases either, but seems to be consistent enough that there is no longer a problem in practice.
Co-authored-by: Andreas Pfurtscheller <1051396+aplr@users.noreply.github.com>
…mbol, constant or number
…ests for <, <= and >= including when answer is equal to response. Add Python package to enable individual tests
- Made criteria keywords protected from input symbol aliasing - Added extra outcome when order or equality comparison generates an error (e.g. when checking if a > b where a and b are functions of x and a > b for some values of x but not for others).
Added ability to replace feedback generated by a specific tag
Physical quantitiy <= fix
…feedback database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.