Skip to content

fix: add noop for fatal type #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
felixmosh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add noop for fatal type #18

felixmosh wants to merge 1 commit into from

Conversation

@felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Jan 12, 2025

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

closes #17
@felixmosh
Copy link
Contributor Author

felixmosh commented Jan 27, 2025

ping?
@felixmosh
Copy link
Contributor Author

felixmosh commented Sep 7, 2025

??
@Mouri-P
Copy link

Mouri-P commented Dec 15, 2025

Since npm log levels don’t include a fatal method, many loggers won’t implement it. It would be more consistent to fall back to error when fatal isn’t available, since that’s the closest npm-level equivalent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@felixmosh @Mouri-P