Allow CORS middleware to send Access-Control-Max-Age: 0 #2518
+61 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… config.MaxAge being negative number.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #2518 +/- ## ========================================== + Coverage 92.82% 92.88% +0.06% ========================================== Files 39 39 Lines 4652 4655 +3 ========================================== + Hits 4318 4324 +6 + Misses 242 240 -2 + Partials 92 91 -1
☔ View full report in Codecov by Sentry. |
vishr approved these changes Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allow CORS middleware to send
Access-Control-Max-Age: 0value (when config.MaxAge is negative number) to instruct browsers not to cache that response. This is backwards compatible change.implements #2471