Skip to content

Conversation

@aldas
Copy link
Contributor

@aldas aldas commented Jul 21, 2023

switch math/random usage to crypto/random

related to #2489

@aldas aldas requested review from lammel and vishr July 21, 2023 06:56
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: -0.05 ⚠️

Comparison is base (4598a4a) 92.82% compared to head (cdd9635) 92.77%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2490 +/- ## ========================================== - Coverage 92.82% 92.77% -0.05%  ========================================== Files 39 39 Lines 4624 4636 +12 ========================================== + Hits 4292 4301 +9  - Misses 241 243 +2  - Partials 91 92 +1 
Impacted Files Coverage Δ
middleware/util.go 87.03% <75.00%> (-3.44%) ⬇️
middleware/csrf.go 89.42% <100.00%> (ø)
middleware/request_id.go 83.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less dependency, great. LGTM!

@aldas aldas merged commit 626f13e into labstack:master Jul 21, 2023
@aldas aldas deleted the mathrandom-to-cryptorandom branch July 22, 2023 15:45
@aldas aldas mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants