Fix group.RouteNotFound not working when group has attached middlewares #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @lammel please review. |
Codecov ReportBase: 92.84% // Head: 92.84% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@ ## master #2411 +/- ## ======================================= Coverage 92.84% 92.84% ======================================= Files 39 39 Lines 4503 4503 ======================================= Hits 4181 4181 Misses 234 234 Partials 88 88
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @lammel ping |
| Sorry, late to the party. |
3 tasks
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix group.RouteNotFound not working when group has attached middlewares.
Problems is/was that
g.Useregisters special catch all routes withg.Anyand those routes have priority over route registered byg.NotFoundHandler.Solution is to register these special routes also with
NotFoundHandlerso if you register custom one - it will override special catch all.Fixes #2401
For history sake: somewhat relates to #1981 , #2256 , #1728