Add start time to request logger middleware values #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1991 +/- ## ======================================= Coverage 91.23% 91.23% ======================================= Files 33 33 Lines 2886 2887 +1 ======================================= + Hits 2633 2634 +1 Misses 161 161 Partials 92 92
Continue to review full report at Codecov.
|
Contributor Author
| @pafuent please review |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add start time to request logger middleware values to get time value just before next middleware/handler was called. Logger middlewares timestamps are for instants after handler
next(c)has returned back to request logger scope.v.StartTimegives you time before.See #1989 (comment)