Skip to content

Conversation

@TheYkk
Copy link
Contributor

@TheYkk TheYkk commented Apr 10, 2021

Related to #1844

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #1845 (13ecc32) into master (bb7f222) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1845 +/- ## ========================================== + Coverage 89.57% 89.60% +0.02%  ========================================== Files 32 31 -1 Lines 2686 2693 +7 ========================================== + Hits 2406 2413 +7  Misses 180 180 Partials 100 100 
Impacted Files Coverage Δ
middleware/jwt.go 79.41% <100.00%> (+1.51%) ⬆️
middleware/timeout.go 100.00% <0.00%> (ø)
middleware/proxy_1_11.go
middleware/proxy.go 66.66% <0.00%> (+6.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7f222...13ecc32. Read the comment docs.

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
@TheYkk TheYkk requested a review from aldas April 20, 2021 11:26
@TheYkk TheYkk mentioned this pull request Apr 20, 2021
3 tasks
@lammel lammel linked an issue Apr 21, 2021 that may be closed by this pull request
3 tasks
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas added this to the v4.3 milestone Apr 27, 2021
@aldas aldas merged commit de3f87e into labstack:master May 8, 2021
@TheYkk TheYkk deleted the jwt-lookup branch May 8, 2021 21:08
@davrux
Copy link

davrux commented May 25, 2021

This is a really nice feature, you should add an explaining comment to the TokenLookup field, that it now supports multiply inputs:

Multiply sources for JWT can be seaprated by comma: "header: Authorization,cookie: myowncookie" 
@bo-er
Copy link

bo-er commented Nov 21, 2023

This is a really nice feature, you should add an explaining comment to the TokenLookup field, that it now supports multiply inputs:

Multiply sources for JWT can be seaprated by comma: "header: Authorization,cookie: myowncookie" 

Thanks but there is a space between header: and Authorization, the correct one should be:

"header:Authorization,cookie: myowncookie" 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants