Skip to content

Conversation

@aldas
Copy link
Contributor

@aldas aldas commented Mar 10, 2021

fix timeout middleware not sending status code when handler returns an error (fix #1804)

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1805 (78d487d) into master (4c2fd1f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #1805 +/- ## ======================================= Coverage 89.49% 89.49% ======================================= Files 32 32 Lines 2684 2685 +1 ======================================= + Hits 2402 2403 +1  Misses 181 181 Partials 101 101 
Impacted Files Coverage Δ
middleware/timeout.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2fd1f...78d487d. Read the comment docs.

Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging.

@lammel lammel merged commit dec96f0 into master Mar 12, 2021
@aldas aldas deleted the fix_1804_timeout_status_code branch January 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants