Uses strings.EqualFold #1790
Merged
Uses strings.EqualFold #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Changes case insensitive string comparisons to string.EqualFold which performs better than strings.Lower(str) == str comparison
Codecov Report
@@ Coverage Diff @@ ## master #1790 +/- ## ======================================= Coverage 89.75% 89.75% ======================================= Files 32 32 Lines 2675 2675 ======================================= Hits 2401 2401 Misses 175 175 Partials 99 99
Continue to review full report at Codecov.
|
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes case insensitive string comparisons to string.EqualFold which performs better than strings.Lower(str) == str comparison
Already covered in test cases:
https://github.com/labstack/echo/blob/master/middleware/basic_auth_test.go#L49
https://github.com/labstack/echo/blob/master/context_test.go#L821