Avoid context canceled errors #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1789 +/- ## ========================================== + Coverage 89.60% 89.63% +0.02% ========================================== Files 32 32 Lines 2656 2663 +7 ========================================== + Hits 2380 2387 +7 Misses 178 178 Partials 98 98
Continue to review full report at Codecov.
|
aldas requested changes Feb 25, 2021
clwluvw force-pushed the context-canceled branch 7 times, most recently from 591dc97 to f5707c8 Compare clwluvw force-pushed the context-canceled branch from f5707c8 to 0d908d9 Compare 
lammel reviewed Mar 2, 2021
clwluvw force-pushed the context-canceled branch 2 times, most recently from b13f4a7 to 216ee0e Compare clwluvw force-pushed the context-canceled branch from 216ee0e to d8c05b4 Compare 
aldas requested changes Mar 7, 2021
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw force-pushed the context-canceled branch from d8c05b4 to d3e0a0b Compare Return 499 Client Closed Request when the client has closed the request before the server could send a response Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw force-pushed the context-canceled branch from d3e0a0b to 01fbe2a Compare aldas approved these changes Mar 7, 2021
This was referenced Mar 8, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Return 499 Client Closed Request when the client has closed the request before the server could send a response
Signed-off-by: Seena Fallah seenafallah@gmail.com