Fix DefaultHTTPErrorHandler with enabled debug (#1477) #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1666 +/- ## ========================================== + Coverage 83.81% 83.97% +0.16% ========================================== Files 28 28 Lines 1909 1910 +1 ========================================== + Hits 1600 1604 +4 + Misses 195 194 -1 + Partials 114 112 -2
Continue to review full report at Codecov.
|
3 tasks
pafuent approved these changes Nov 5, 2020
Contributor Author
| Thanks for the review @pafuent . |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR will correct the misbehaviour described in issue #1477.
With enabled debug still the correct error will be returned and not overwritten.
Tests are added, where the now expected errors are shown