Fixed panic when Router#Find fails on Param paths #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed panic when Router#Find fails to find a route that could match a Param route that only have children routes and no root route. e.g /create /:id/edit /:id/active Finding /creates results in panic because the router tree node that belongs to the param route :id don't have pnames on it. The childrens of :id (:id/edit and :id/active) have the pnames properly set, but those are not processed because /creates don't match on those paths.
Codecov Report
@@ Coverage Diff @@ ## master #1659 +/- ## ======================================= Coverage 84.98% 84.99% ======================================= Files 29 29 Lines 1958 1959 +1 ======================================= + Hits 1664 1665 +1 Misses 187 187 Partials 107 107
Continue to review full report at Codecov.
|
3 tasks
Contributor
| Oh, forgot to review. This relates to #1661 and should be reviewed together. |
Contributor
| Please remove the go.sum changes in this PR as they are unrelated to the patch. |
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed panic when Router#Find fails to find a route that could match a Param route that only have children routes and no root route.
e.g
/create
/:id/edit
/:id/active
Finding /creates results in panic because the router tree node that belongs to the param route :id don't have pnames on it. The childrens of :id (:id/edit and :id/active) have the pnames properly set, but those are not processed because /creates don't match on those paths.
This fix #1653