cors allow regex pattern #1623
Merged
cors allow regex pattern #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1623 +/- ## ========================================== + Coverage 85.08% 85.20% +0.12% ========================================== Files 28 28 Lines 2185 2203 +18 ========================================== + Hits 1859 1877 +18 Misses 212 212 Partials 114 114
Continue to review full report at Codecov.
|
enable cors to use regex pattern for allowed origins implementation is similar to another popular cors middleware: https://github.com/astaxie/beego/blob/master/plugins/cors/cors.go#L196-L201
KlotzAndrew force-pushed the cors_regex branch from bbe8e46 to 9a28fb8 Compare 
lammel approved these changes Sep 1, 2020
Contributor
lammel left a comment
lammel left a comment There was a problem hiding this comment.
Looking good.
A small performance penalty is expected for CORS checks due to the regex matching used.
Tests available to check for plaintext and regex matches.
Contributor
| @KlotzAndrew Thanks for your contribution! |
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
enable cors to use regex pattern for allowed origins
implementation is similar to another popular cors middleware: https://github.com/astaxie/beego/blob/master/plugins/cors/cors.go#L196-L201