Fix recover print stack trace log level #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1604 +/- ## ========================================== + Coverage 84.96% 85.04% +0.08% ========================================== Files 28 28 Lines 2168 2180 +12 ========================================== + Hits 1842 1854 +12 Misses 211 211 Partials 115 115
Continue to review full report at Codecov.
|
vishr approved these changes Jul 5, 2020
Member
| @178inaba Do you mind updating the docs? They are located here https://github.com/labstack/echox/blob/master/website/content/middleware/recover.md. |
Contributor Author
| @vishr |
vishr pushed a commit that referenced this pull request Aug 28, 2020
…1572) * The directory path does not end with '/', it needs to be redirected * changed guide highlighting to shell (#1593) * Fix recover print stack trace log level (#1604) * Fix recover print stack trace log level * Add recover log level test * Add default LogLevel to DefaultRecoverConfig Co-authored-by: solym <ymwh@foxmai.com> Co-authored-by: roz3x <52892437+roz3x@users.noreply.github.com> Co-authored-by: Masahiro Furudate <178inaba.git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed to be able to set the log level of stack trace when
recover.Fixes #1605.