dtInstance doesn't return Promise #1548
Conversation
- update docs and demo project
There was a problem hiding this comment.
issue: I added the promise feature because there were cases where the dtOptions comes from the server. See https://l-lin.github.io/angular-datatables/#/advanced/load-dt-options-with-promise
- removed misc import
There was a problem hiding this comment.
issue: The basic example "angular-way" doesn't seem to work with this change.
suggestion: This is a breaking change. We should not forget to add this information when releasing the newest version. Maybe add this change only in version 12, as it's a major version?
Co-authored-by: Louis LIN <l-lin@users.noreply.github.com>
Co-authored-by: Louis LIN <l-lin@users.noreply.github.com>
| @l-lin thanks for the suggested changes. I've added them as requested. And yes. I do not plan on backporting this PR to older versions. It will be a v12+ thing only. We talked about this over email a few months ago, remember? I also remember attaching a git patch as POC for this. I'm looking into angular way bug, will update when fixed. |
| const { ref, context } = el.ngTemplateRef; | ||
| // get <td> element which holds data using index | ||
| const columnIndex = columns.findIndex(e => e.data === el.data); | ||
| const cellFromIndex = row.childNodes.item(index); |
There was a problem hiding this comment.
| const cellFromIndex = row.childNodes.item(index); | |
| const cellFromIndex = row.childNodes.item(columnIndex); |
| Hey, I've realised this feature isn't going to work with how we setup datatables.net library. I'm closing this for now with hope to revive it in the future, maybe Angular v13? |
2 participants
Getting this off the list before upgrade to v12