Skip to content

KEP 4355 - CoordinatedLeaderElection to Beta Docs #49950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Apr 8, 2025
Merged

KEP 4355 - CoordinatedLeaderElection to Beta Docs #49950

k8s-ci-robot merged 2 commits into from
Apr 8, 2025

Conversation

@Jefftree
Copy link
Member

@Jefftree Jefftree commented Feb 27, 2025 •
edited
Loading

Description

kubernetes/enhancements#4355

Issue

Closes: #
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2e68103
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f49e809b8d73000870c415
@netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e68103
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f49e8001724c0008bc9a6e
😎 Deploy Preview https://deploy-preview-49950--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@dipesh-rawat dipesh-rawat mentioned this pull request Mar 18, 2025
Open
8 tasks
@rayandas
Copy link
Member

rayandas commented Mar 25, 2025

Hello @Jefftree 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2025
@Jefftree Jefftree changed the title [WIP] KEP 4355 - CLE to Beta Docs KEP 4355 - CLE to Beta Docs Mar 26, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2025
jpbetz
jpbetz approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
For technical content
@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

/assign @kubernetes/sig-docs-leads for a review.
@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

Hello @Jefftree 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!
@Jefftree @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
2e68103 
…-gates/CoordinatedLeaderElection.md Co-authored-by: Qiming Teng <tengqm@outlook.com>
@tengqm tengqm changed the title KEP 4355 - CLE to Beta Docs KEP 4355 - CoordinatedLeaderElection to Beta Docs Apr 8, 2025
@tengqm
Copy link
Contributor

tengqm commented Apr 8, 2025

The upstream change is in.
/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2025

LGTM label has been added.

DetailsGit tree hash: 67866fb54cf08bed8a26ab696fb221ed370a6097
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@tengqm tengqm added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 8, 2025
@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

Seems like the lgtm and approve labels got remove by the tide label. Does this PR require another lgtm and approval?
@jpbetz
Copy link
Contributor

jpbetz commented Apr 8, 2025

/approve
/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2025

LGTM label has been added.

DetailsGit tree hash: 67866fb54cf08bed8a26ab696fb221ed370a6097
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit a368f55 into kubernetes:dev-1.33 Apr 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

5 participants

@Jefftree @rayandas @tengqm @k8s-ci-robot @jpbetz