Skip to content

[ja] Translate docs/tasks/configure-pod-container/pull-image-private-registry.md #48966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2024
Merged

[ja] Translate docs/tasks/configure-pod-container/pull-image-private-registry.md #48966

merged 2 commits into from
Dec 13, 2024

Conversation

@ym1024
Copy link
Contributor

@ym1024 ym1024 commented Dec 7, 2024

Description

Translate content/en/docs/tasks/configure-pod-container/pull-image-private-registry.md into Japanese.

Issue

Closes: #48888
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Dec 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from kakts and t-inu December 7, 2024 14:17
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2024
@netlify
Copy link

netlify bot commented Dec 7, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2845b2b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/675b0a30aead2e00080cc38c
😎 Deploy Preview https://deploy-preview-48966--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
@ym1024 ym1024 force-pushed the add_pull-image-private-registry_md branch from 273d611 to b2ef61b Compare December 7, 2024 14:47
@ym1024
Copy link
Contributor Author

ym1024 commented Dec 7, 2024 •
edited
Loading

Preview page: https://deploy-preview-48966--kubernetes-io-main-staging.netlify.app/ja/docs/tasks/configure-pod-container/pull-image-private-registry/
@ym1024 ym1024 force-pushed the add_pull-image-private-registry_md branch from b2ef61b to ca61155 Compare December 7, 2024 19:51
@kakts
Copy link
Member

kakts commented Dec 9, 2024

/lgtm

Thank you for translating.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2024

LGTM label has been added.

Git tree hash: 8d9fa312dc48af8716f92428c04c32b3da3a557e
t-inu
t-inu reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしましたので、ご確認ください。
@t-inu
Copy link
Member

t-inu commented Dec 12, 2024

pull(プル)について
#47615 (comment)
#46802 (comment)

私もどこで話題になったか思い出せないのですが、本PRでも「取得する」にしておきたいかなと。
ただ、"image pull secret" については、全部カタカナか、あるいは訳さないかのどちらかという気がします。
どちらにするかは悩むところですが…。
cc @kubernetes/sig-docs-ja-reviews
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kakts December 12, 2024 15:57
@ym1024 ym1024 force-pushed the add_pull-image-private-registry_md branch from 7554886 to 2845b2b Compare December 12, 2024 16:07
@ym1024
Copy link
Contributor Author

ym1024 commented Dec 12, 2024

@t-inu
レビューありがとうございます。
コメントいただいた点の修正をコミットしました。
2845b2b

pull(プル)については、「イメージプルシークレット」以外はより分かりやすい「取得する」にしましたが、他のレビュワーの方からのコメントがあるか待ちたいと思います。

/label tide/merge-method-squash
@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 12, 2024
@Okabe-Junya
Copy link
Member

Okabe-Junya commented Dec 12, 2024

pull(プル)について #47615 (comment) #46802 (comment)

私もどこで話題になったか思い出せないのですが、本PRでも「取得する」にしておきたいかなと。

取得する +1 です（以前nasa-sanともどこかで会話した記憶はありますが...）
Okabe-Junya
Okabe-Junya reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
/approve
/cc t-inu
@k8s-ci-robot k8s-ci-robot requested a review from t-inu December 13, 2024 04:26
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kakts, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
t-inu
t-inu reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2024

LGTM label has been added.

Git tree hash: c97434ccc9fa130f00e7ec9411fb09e9e156c791
@k8s-ci-robot k8s-ci-robot merged commit 44ae714 into kubernetes:main Dec 13, 2024
6 checks passed
@ym1024 ym1024 deleted the add_pull-image-private-registry_md branch December 13, 2024 17:05
Andygol pushed a commit to Andygol/k8s-website that referenced this pull request Dec 31, 2024
@ym1024 @Andygol
[ja] Translate docs/tasks/configure-pod-container/pull-image-private-…
67964b5 
…registry.md (kubernetes#48966) * [ja] Translate docs/tasks/configure-pod-container/pull-image-private-registry.md * [ja] Apply suggestions from PR review
rayandas pushed a commit to rayandas/website that referenced this pull request Jan 24, 2025
@ym1024 @rayandas
[ja] Translate docs/tasks/configure-pod-container/pull-image-private-…
ce15c92 
…registry.md (kubernetes#48966) * [ja] Translate docs/tasks/configure-pod-container/pull-image-private-registry.md * [ja] Apply suggestions from PR review
@t-inu t-inu mentioned this pull request Jun 9, 2025
Merged
@t-inu t-inu mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

5 participants

@ym1024 @kakts @k8s-ci-robot @t-inu @Okabe-Junya