Skip to content

Conversation

@catinbag
Copy link
Contributor

Localization of the Pods page

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from Arhell and shurup April 23, 2024 08:02
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ru Issues or PRs related to Russian language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @catinbag!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2024
@netlify
Copy link

netlify bot commented Apr 23, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 21c42a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67497cbf626b3e0008b17205
😎 Deploy Preview https://deploy-preview-45980--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

@catinbag Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: https://git.k8s.io/community/CLA.md

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2024
@catinbag
Copy link
Contributor Author

/easycla

@catinbag
Copy link
Contributor Author

@dipesh-rawat could you take a look?

@shurup
Copy link
Member

shurup commented Apr 24, 2024

@catinbag since the robot added the cncf-cla: yes label, your EasyCLA check passed successfully now. Please wait for the Russian-speaking members to review your files 🙏

@shurup shurup requested a review from kirkonru April 24, 2024 06:38
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b3fe63fd21f9bc775c13cb68e953d5eaded5fb9

@Arhell Arhell removed their assignment Apr 24, 2024
@catinbag catinbag changed the title [ru] Localization of content/ru/docs/concepts/containers/_index.md [ru] Localization of content/ru/docs/concepts/workloads/pods/_index.md Apr 24, 2024
@catinbag
Copy link
Contributor Author

Hey @shurup @kirkonru 👋 , could you take a look?

@shurup
Copy link
Member

shurup commented Apr 29, 2024

Hi @catinbag! We decided to transliterate Pods fully, so we use «Поды»/«поды». The first one is preferable when they are called Pods (not pods) in English, i.e. when we refer to the formal name of one of Kubernetes API objects.

At the same time, we prefer to keep the original English name in commas when this term is mentioned for the first time. Can you please revise your text accordingly 🙏 Feel free to use declensions when needed (e.g., «у пода», «в поде», etc.).

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@catinbag catinbag force-pushed the ru_translate_pods branch from f3295f1 to c4171c7 Compare May 1, 2024 11:01
@catinbag
Copy link
Contributor Author

catinbag commented May 1, 2024

@shurup I translated Pods, but I have a question: should we translate PodTemplate?

@shurup
Copy link
Member

shurup commented May 3, 2024

should we translate PodTemplate?

No, we leave it in English 👍
Thanks! I'll review your whole text now.

Copy link
Member

@shurup shurup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't be afraid of how many corrections I suggest — there are primarily tiny fixes 😅 Importantly, one piece needs to be updated according to the actual docs. When everything is done, please squash your commits so we can merge your PR with the only commit in it 🙏

Co-authored-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2024
@kirkonru
Copy link
Contributor

kirkonru commented Aug 3, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2024
@shurup
Copy link
Member

shurup commented Aug 6, 2024

Hi @catinbag! Will you find some time to go through the suggestions from my review? There's not much left to finalise and merge this translation 🙏

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2024
@shurup
Copy link
Member

shurup commented Nov 27, 2024

/remove-lifecycle stale

If @catinbag isn't able to finalise the PR, I think I can do it.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 29, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@shurup
Copy link
Member

shurup commented Nov 29, 2024

I fixed all remaining issues and resolved them (thus, my review is complete now, and I have approved the PR). On my side, this PR is ready to merge. Now, expecting @Arhell or @kirkonru to finally LGTM it.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 29, 2024
Copy link
Contributor

@kirkonru kirkonru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirkonru, shurup

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kirkonru
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13213072781bde0e67ab341d9d4424776060b293

@k8s-ci-robot k8s-ci-robot merged commit f73ef83 into kubernetes:main Nov 29, 2024
6 checks passed
Andygol pushed a commit to Andygol/k8s-website that referenced this pull request Dec 31, 2024
kubernetes#45980) * [ru] Localization of content/ru/docs/concepts/containers/_index.md * Replaced Pod -> Под * Apply suggestions from code review Co-authored-by: Dmitry Shurupov <dmitry.shurupov@palark.com> * Actualising the Pod OS translation * Tiny fixes following the review --------- Co-authored-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

7 participants