Skip to content

Conversation

@alculquicondor
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot requested a review from soltysh October 17, 2023 13:31
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 53bc63d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652ea935321c7a0008937415
😎 Deploy Preview https://deploy-preview-43529--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target dev-1.29 branch, IMO.

@sftim
Copy link
Contributor

sftim commented Oct 17, 2023

/sig storage

/hold
until the query about target branch is addressed

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 17, 2023
@sftim
Copy link
Contributor

sftim commented Oct 17, 2023

Oops
/sig apps
/remove-sig storage

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 17, 2023
@alculquicondor alculquicondor changed the base branch from main to dev-1.29 October 17, 2023 15:33
@alculquicondor
Copy link
Member Author

Oops, I fixed the target

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2023
@netlify
Copy link

netlify bot commented Nov 10, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 3be75f2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/654e88dfdbd3390008db528d
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2023
@tengqm
Copy link
Contributor

tengqm commented Nov 11, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2023
@dejanzele
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6847e5c90413d9a8bf0d8eef01b20ad69395b80

@alculquicondor
Copy link
Member Author

/hold cancel

I changed the branch long time ago :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9e36b6c into kubernetes:dev-1.29 Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

5 participants