Skip to content

Conversation

@pjhwa
Copy link
Contributor

@pjhwa pjhwa commented May 16, 2020

Closes #20995

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from ianychoi and ysyukr May 16, 2020 01:10
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 16, 2020
@netlify
Copy link

netlify bot commented May 16, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 6065f7e

https://deploy-preview-21003--k8s-dev-ko.netlify.app

@pjhwa
Copy link
Contributor Author

pjhwa commented May 16, 2020

Hugo 업그레이드 후에 note 블럭 같은 부분이 깨지는 이슈( #20921 )가 있습니다.
이 문서(en/ko) 역시 동일한 문제를 가지고 있습니다. 일부 해결하려는 시도( #20484 )가 있었던 것 같습니다만, 여전히 고쳐지질 않고 있네요.
일단은 원문이 고쳐진 이후에 블럭 깨지는 이슈는 조치해야할 것 같습니다. 참고하세요.

@claudiajkang
Copy link
Contributor

/assign @ysyukr

Copy link
Contributor

@ysyukr ysyukr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 제안을 드립니다.
확인 및 업데이트 부탁드립니다.

@pjhwa
Copy link
Contributor Author

pjhwa commented May 26, 2020

@ysyukr 리뷰 감사합니다!
의견 주신 내용은 모두 반영하였습니다.

@pjhwa pjhwa force-pushed the translate-20995 branch from fb23d28 to 6065f7e Compare May 26, 2020 21:09
@ysyukr
Copy link
Contributor

ysyukr commented May 28, 2020

@pjhwa 고생하셨습니다. 😄
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ysyukr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad4df6f into kubernetes:dev-1.18-ko.4 May 28, 2020
gochist pushed a commit that referenced this pull request May 30, 2020
- Translate docs/reference/issues-security/_index.md into Korean (#21145) - Translate tasks/administer-cluster/kubeadm/adding-windows-nodes.md into Korean (#21003) - Translate manage-resources/memory-default-namespace.md into Korean (#21089) - Translate tasks/configure-pod-container/pull-image-private-registry in Korean (#21036) - Translate contribute/advanced.md into Korean (#21002) - Update to Outdated files in the dev-1.18-ko.4 branch. (#21102) - Translate manage-resources/cpu-constraint-namespace.md into Korean (#21048) - Translate manage-resources/memory-constraint-namespace.md into Korean (#21091) - Translate setup/release/notes.md in Korean (#21158) - Translate manage-resources/quota-pod-namespace.md into Korean (#21087) - Translate tasks/administer-cluster/kubeadm/upgrading-windows-nodes.md into Korean (#20999) - Translate tasks/administer-cluster/kubeadm/kubeadm-certs.md into Korean (#21000) - Translate manage-resources/quota-memory-cpu-namespace.md into Korean (#21088) - Translate manage-resources/cpu-default-namespace.md into Korean (#21090) - Translate contribute/suggesting-improvements.md into Korean (#21001) - Translate quality-service-pod in Korean (#21081) Co-authored-by: Jerry Park <jaehwa@gmail.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: DongMoon Kim <dmoons.kim@gmail.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: Yuk, Yongsu <ysyukr@gmail.com> Co-authored-by: bluefriday <bluefriday86@gmail.com>
denkensk pushed a commit to denkensk/website that referenced this pull request Jun 8, 2020
- Translate docs/reference/issues-security/_index.md into Korean (kubernetes#21145) - Translate tasks/administer-cluster/kubeadm/adding-windows-nodes.md into Korean (kubernetes#21003) - Translate manage-resources/memory-default-namespace.md into Korean (kubernetes#21089) - Translate tasks/configure-pod-container/pull-image-private-registry in Korean (kubernetes#21036) - Translate contribute/advanced.md into Korean (kubernetes#21002) - Update to Outdated files in the dev-1.18-ko.4 branch. (kubernetes#21102) - Translate manage-resources/cpu-constraint-namespace.md into Korean (kubernetes#21048) - Translate manage-resources/memory-constraint-namespace.md into Korean (kubernetes#21091) - Translate setup/release/notes.md in Korean (kubernetes#21158) - Translate manage-resources/quota-pod-namespace.md into Korean (kubernetes#21087) - Translate tasks/administer-cluster/kubeadm/upgrading-windows-nodes.md into Korean (kubernetes#20999) - Translate tasks/administer-cluster/kubeadm/kubeadm-certs.md into Korean (kubernetes#21000) - Translate manage-resources/quota-memory-cpu-namespace.md into Korean (kubernetes#21088) - Translate manage-resources/cpu-default-namespace.md into Korean (kubernetes#21090) - Translate contribute/suggesting-improvements.md into Korean (kubernetes#21001) - Translate quality-service-pod in Korean (kubernetes#21081) Co-authored-by: Jerry Park <jaehwa@gmail.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: DongMoon Kim <dmoons.kim@gmail.com> Co-authored-by: Jesang Myung <jesang.myung@gmail.com> Co-authored-by: Yuk, Yongsu <ysyukr@gmail.com> Co-authored-by: bluefriday <bluefriday86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

4 participants