Skip to content

golang: Build 1.21rc3 images #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Jul 19, 2023
Merged

golang: Build 1.21rc3 images #3155

k8s-ci-robot merged 2 commits into from
Jul 19, 2023

Conversation

@cpanato
Copy link
Member

@cpanato cpanato commented Jul 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.21rc3 images

/hold
/assign @saschagrunert @ameukam @Verolop @palnabarun
cc @kubernetes/release-managers @liggitt

Which issue(s) this PR fixes:

Related to #3076

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- golang: Build 1.21rc3 images
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2023
@cpanato cpanato changed the title golang: Build 1.21rc2 images golang: Build 1.21rc3 images Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot requested review from jimangel and jrsapi July 17, 2023 07:32
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@cpanato
Copy link
Member Author

cpanato commented Jul 17, 2023

/test pull-release-image-go-runner
@cpanato
Copy link
Member Author

cpanato commented Jul 17, 2023

images are not available, will wait :/ tictac...
@cpanato
Copy link
Member Author

cpanato commented Jul 18, 2023

/test pull-release-image-go-runner
/test pull-release-image-releng-ci
@cpanato
Copy link
Member Author

cpanato commented Jul 18, 2023

/test pull-release-image-kube-cross
@cpanato
Copy link
Member Author

cpanato commented Jul 18, 2023

/unhold
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@saschagrunert
Copy link
Member

saschagrunert commented Jul 18, 2023

@cpanato I assume we do the switch to 1.21 and bookworm in one rush, right?
@cpanato
Copy link
Member Author

cpanato commented Jul 18, 2023

@saschagrunert i guess :)
saschagrunert
saschagrunert requested changes Jul 18, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@saschagrunert saschagrunert mentioned this pull request Jul 18, 2023
Closed
44 tasks
@cpanato cpanato requested a review from saschagrunert July 18, 2023 11:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2023
cpanato added 2 commits July 19, 2023 12:04
@cpanato
golang: Build 1.21rc2 images
df6cd94 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
update k8s-ci-builder dockerfile
e1c7991 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Jul 19, 2023

/retest
@cpanato
Copy link
Member Author

cpanato commented Jul 19, 2023

PTAL @saschagrunert
@ameukam
Copy link
Member

ameukam commented Jul 19, 2023

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit ef65d89 into kubernetes:master Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 19, 2023
@cpanato cpanato deleted the golang121rc3 branch July 19, 2023 17:14
@cpanato cpanato mentioned this pull request Jul 20, 2023
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

6 participants

@cpanato @saschagrunert @k8s-ci-robot @ameukam @Verolop @palnabarun