Add arbitray system log support #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added the cncf-cla: yes 
Random-Liu force-pushed the add-arbitray-log-support branch from 5864dcf to b7032bf Compare 
Member Author
| I've updated the e2e test locally according the change in this PR, and the PR passed the test. Will update the e2e test in Kubernetes repo after this PR is merged. |
This was referenced Feb 7, 2017
Member
| Can you rebased this one? #81 was merged, and I am reviewing this one today. |
Random-Liu force-pushed the add-arbitray-log-support branch from b7032bf to f2ebf21 Compare 
Random-Liu force-pushed the add-arbitray-log-support branch from f2ebf21 to 01334e7 Compare Member Author
| @dchen1107 Rebased. :) |
Random-Liu changed the title Member
| LGTM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For #44.
Based on #81.
This PR:
PluginConfigfor plugin specific configuration.sourcein journald plugin configuration to make sdjournalSYSTEM_IDENTIFIERconfigurable.timestampregular expression,messageregular expression andtimestampFormatconfiguration in syslog plugin configuration. (We plan to change this to befilelog, because it can handle not only syslog)TODOs for this work:
syslogtofilelog.kernel monitortosystem log monitor, change all "kernel" reference in the code./cc @dchen1107 @kubernetes/node-problem-detector-reviewers
This change is