Skip to content

Update README.md #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2017
Merged

Update README.md #57

merged 1 commit into from
Jan 5, 2017

Conversation

@kewubenduben
Copy link
Contributor

@kewubenduben kewubenduben commented Dec 27, 2016 •
edited by k8s-reviewable
Loading

This change is Reviewable
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 27, 2016

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 27, 2016
@andyxning
Copy link
Member

andyxning commented Dec 28, 2016

@thecantero Could you please sign the cla? :)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 28, 2016
@andyxning
Copy link
Member

andyxning commented Dec 28, 2016

/lgtm

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 28, 2016

@andyxning: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.
@andyxning
Copy link
Member

andyxning commented Dec 28, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@Random-Liu
Copy link
Member

Random-Liu commented Jan 5, 2017 •
edited
Loading

/lgtm

@thecantero @andyxning Thanks for your help!
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 5, 2017

@Random-Liu: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm

@andyxning Thanks for your help!

If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@Random-Liu Random-Liu self-assigned this Jan 5, 2017
@Random-Liu
Copy link
Member

Random-Liu commented Jan 5, 2017

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2017
@Random-Liu Random-Liu merged commit b4626e0 into kubernetes:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.

5 participants

@kewubenduben @k8s-ci-robot @andyxning @Random-Liu @thecantero