Skip to content

Conversation

@juliusmilan
Copy link
Contributor

@juliusmilan juliusmilan commented May 10, 2017

This PR contains 2 changes.

  • First is README update, that contains documented use of ABRT by NPD, my leader asked me to do.
  • Second is abrt-adaptor ccpp pattern fix, I found it didn't catch all possible cpp problem messages produced by ABRT.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2017
This modifies pattern for catching cpp problem messages produced by ABRT. Found that not all mentioned messages fit into former pattern. For example following is valid cpp problem message produced by ABRT: Process xxx (bad_binary) crashed in Will::Fail::a() [clone .isra.2]() but doesn't fit former pattern, since it's last part contains whitespaces.
@juliusmilan juliusmilan force-pushed the abrt-readme-and-ccpp-fix branch from e3ae162 to 750db41 Compare May 11, 2017 14:25
Add description of ABRT usage.
@juliusmilan juliusmilan force-pushed the abrt-readme-and-ccpp-fix branch from 750db41 to 6966797 Compare May 12, 2017 13:21
@Random-Liu
Copy link
Member

LGTM

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2017
@Random-Liu Random-Liu self-assigned this May 15, 2017
@Random-Liu Random-Liu merged commit 9f20903 into kubernetes:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.

3 participants