Introduce kuberc view/set commands under kubectl alpha #135003

ardaguclu · 2025-10-31T09:50:53Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR introduces two commands under kubectl alpha for kuberc file operations.

kubectl alpha kuberc view: This command views the kuberc file (either explicitly defined via --kuberc or KUBERC env var or default location).
kubectl alpha kuberc set: This command creates/updates kuberc file (either in default location or explicitly defined via --file).

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#3104

Does this PR introduce a user-facing change?

Adding new kuberc view/set commands in kubectl to perform operations against kuberc file

Special notes for your reviewer:

Claude helped me preparation of this PR (but this is not a bulk generated PR).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/3104-introduce-kuberc

ardaguclu · 2025-10-31T09:51:11Z

/triage accepted
/priority important-longterm

ardaguclu · 2025-10-31T09:51:37Z

/cc @soltysh @mpuckett159 @eddiezane

ardaguclu · 2025-10-31T09:52:33Z

/hold
for review

ardaguclu · 2025-10-31T11:21:32Z

/retest

soltysh

This is great - thank you! But I left a bunch of comments 😅

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/kuberc.go

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/kuberc.go

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set.go

soltysh · 2025-11-03T12:42:52Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set.go

+}
+
+var pref v1beta1.Preference
+if err := yaml.Unmarshal(data, &pref); err != nil {


Same argument about decoding prefs.

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set.go

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set_test.go

soltysh · 2025-11-03T12:53:46Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

+return fmt.Errorf("kuberc file not found at %s", o.KubeRCFile)
+}
+return fmt.Errorf("error reading kuberc file: %w", err)
+}


I believe we've agreed that when running kubectl kuberc view w/o any flags, so for the default location ($HOME/.kube/kuberc) and with the file NOT existing, we would create the default one for the user. No?

I've updated the code to generate a recommended preference file by first prompting to the user. Please let me know your thoughts about the mechanism and flow.

This is great! One suggestion I have is to create a DefaultPreferences function, again in staging/src/k8s.io/kubectl/pkg/kuberc/ directory and just re-use it here. This way we'll have all of kuberc management in a single spot. This way when promoting to GA we'll update all of those helpers to always produce the latest version.

ardaguclu · 2025-11-04T08:21:30Z

staging/src/k8s.io/kubectl/pkg/kuberc/kuberc.go

 explicitly = true
 }

-if kubeRCFile == "" && os.Getenv("KUBERC") != "" {


This seems to be the bug. kubeRCFile can't be empty.

Good catch 😅

ardaguclu · 2025-11-04T08:25:36Z

/retest

ardaguclu · 2025-11-04T09:13:58Z

unrelated
/retest

soltysh

A few comments, mostly non-blocking. Let's sync on slack, if you're able to pick them up before the freeze.

soltysh · 2025-11-05T06:33:01Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/kuberc.go

+}
+
+// SavePreference saves the preference to the kuberc file
+func SavePreference(pref *v1beta1.Preference, file string, out io.Writer) error {


For some time in the future, I think we would want all kuberc management function inside staging/src/k8s.io/kubectl/pkg/kuberc/ directory. We already have there marshal.go so saving that file would be a natural place as well.

This file has been moved under pkg/kuberc.

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

soltysh · 2025-11-05T06:37:57Z

staging/src/k8s.io/kubectl/pkg/kuberc/kuberc.go

 explicitly = true
 }

-if kubeRCFile == "" && os.Getenv("KUBERC") != "" {


Good catch 😅

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

soltysh · 2025-11-05T06:45:35Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

+return fmt.Errorf("kuberc file not found at %s", o.KubeRCFile)
+}
+return fmt.Errorf("error reading kuberc file: %w", err)
+}


This is great! One suggestion I have is to create a DefaultPreferences function, again in staging/src/k8s.io/kubectl/pkg/kuberc/ directory and just re-use it here. This way we'll have all of kuberc management in a single spot. This way when promoting to GA we'll update all of those helpers to always produce the latest version.

soltysh · 2025-11-05T06:47:08Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/view.go

+}
+
+var pref *v1beta1.Preference
+if err := yaml.Unmarshal(data, &pref); err != nil {


That's odd, I'll look into it, so let's leave it for a followup.

soltysh · 2025-11-05T06:52:24Z

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set.go

+},
+}
+
+cmd.Flags().StringVar(&o.KubeRCFile, "file", o.KubeRCFile, "Path to the kuberc file to modify. If it is not specified, default kuberc location will be used.")


I think it should not matter, we should use only one flag for consistency. If you look into what we're doing in kubectl config commands, all of them rely on the built-in --kubeconfig flag. So introducing a different name here, would be confusing.

staging/src/k8s.io/kubectl/pkg/cmd/kuberc/set.go

ardaguclu · 2025-11-05T08:10:07Z

/retest

soltysh · 2025-11-05T08:13:16Z

/label tide/merge-method-squash

soltysh

/lgtm
/approve

k8s-ci-robot · 2025-11-05T08:14:39Z

LGTM label has been added.

Git tree hash: 1b10d35cf414d1093812d1246e9f6e1ab388659a

soltysh · 2025-11-05T08:14:41Z

/hold cancel

k8s-ci-robot · 2025-11-05T08:14:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/kubectl/OWNERS~~ [ardaguclu,soltysh]
~~test/cmd/OWNERS~~ [ardaguclu,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…5003) * Introduce kuberc view/set commands under kubectl alpha * Apply requested changes * Apply requested changes

k8s-ci-robot requested review from mpuckett159 and seans3 October 31, 2025 09:51

github-project-automation bot added this to SIG CLI Oct 31, 2025

k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 31, 2025

github-project-automation bot moved this to Needs Triage in SIG CLI Oct 31, 2025

k8s-ci-robot requested review from eddiezane and soltysh October 31, 2025 09:51

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025

ardaguclu force-pushed the kuberc-cmds branch from 87f2309 to e6223d8 Compare October 31, 2025 10:23

rayandas mentioned this pull request Nov 1, 2025

Separate kubectl user preferences from cluster configs kubernetes/enhancements#3104

Open

12 tasks

soltysh mentioned this pull request Nov 3, 2025

new: add kuberc aliases in kubectl help #134978

Open

soltysh reviewed Nov 3, 2025

View reviewed changes

ardaguclu added 2 commits November 4, 2025 11:17

Introduce kuberc view/set commands under kubectl alpha

d268d2b

Apply requested changes

a99628e

ardaguclu force-pushed the kuberc-cmds branch from 396d67a to a99628e Compare November 4, 2025 08:17

ardaguclu commented Nov 4, 2025

View reviewed changes

soltysh reviewed Nov 5, 2025

View reviewed changes

Apply requested changes

7ed6a94

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 5, 2025

soltysh approved these changes Nov 5, 2025

View reviewed changes

k8s-ci-robot assigned soltysh Nov 5, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025

k8s-ci-robot merged commit 9cad3f8 into kubernetes:master Nov 5, 2025
13 checks passed

k8s-ci-robot added this to the v1.35 milestone Nov 5, 2025

github-project-automation bot moved this from Needs Triage to Done in SIG CLI Nov 5, 2025

ardaguclu deleted the kuberc-cmds branch November 5, 2025 09:56

ardaguclu mentioned this pull request Dec 1, 2025

Can't provide filepath via KUBERC environment variable kubernetes/kubectl#1802

Closed

kfess mentioned this pull request Dec 4, 2025

kubectl alpha kuberc set command clears existing options when --overwrite is used without --option kubernetes/kubectl#1804

Open

Introduce kuberc view/set commands under kubectl alpha #135003

Introduce kuberc view/set commands under kubectl alpha #135003

Uh oh!

Conversation

ardaguclu commented Oct 31, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Does this PR introduce a user-facing change?

Special notes for your reviewer:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

ardaguclu commented Oct 31, 2025

ardaguclu commented Oct 31, 2025

ardaguclu commented Oct 31, 2025

ardaguclu commented Oct 31, 2025

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ardaguclu commented Nov 4, 2025

ardaguclu commented Nov 4, 2025

soltysh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Nov 5, 2025

soltysh commented Nov 5, 2025

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 5, 2025

soltysh commented Nov 5, 2025

k8s-ci-robot commented Nov 5, 2025

Uh oh!

Labels

3 participants