Skip to content

Add new partial/full sync time metrics for iptables kube-proxy #117787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

Add new partial/full sync time metrics for iptables kube-proxy #117787

merged 1 commit into from
May 8, 2023

Conversation

@danwinship
Copy link
Contributor

What type of PR is this?

/kind feature
/sig network
/priority important-soon

What this PR does / why we need it:

Adds separate metrics for full sync time and partial sync time, as discussed in KEP-3453.

Does this PR introduce a user-facing change?

kube-proxy in iptables mode now has separate `sync_full_proxy_rules_duration_seconds` and `sync_partial_proxy_rules_duration_seconds` (in addition to the existing `sync_proxy_rules_duration_seconds`), to give better information about how long each sync type is taking, rather than only giving a weighted average of the two sync types together.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3453

/assign @wojtek-t
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@danwinship danwinship mentioned this pull request May 4, 2023
Closed
15 tasks
wojtek-t
wojtek-t reviewed May 4, 2023
View reviewed changes
pkg/proxy/metrics/metrics.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrisonnet - can you please take a look at the newly added metrics from SIG instrumentation POV?

From my perspective it looks fine - I'm only wondering if we should have two metrics or one metric with a label of "full/partial".
@danwinship danwinship force-pushed the iptables-restore-metrics branch from 1e660d0 to 8138243 Compare May 5, 2023 12:12
@aojea
Copy link
Member

aojea commented May 5, 2023

LGTM

defer to @wojtek-t final lgtm
@danwinship danwinship force-pushed the iptables-restore-metrics branch from 8138243 to 3592312 Compare May 5, 2023 14:14
@danwinship danwinship force-pushed the iptables-restore-metrics branch from 3592312 to cd51c18 Compare May 6, 2023 02:49
@danwinship
Copy link
Contributor Author

(rebased for merge conflict)
@wojtek-t
Copy link
Member

wojtek-t commented May 8, 2023

/lgtm
/retest
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6092c0368ce1452c31409280b4c3e6c5834b7e23
@k8s-ci-robot k8s-ci-robot merged commit f418411 into kubernetes:master May 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 8, 2023
@danwinship danwinship deleted the iptables-restore-metrics branch May 8, 2023 13:21
@aojea aojea mentioned this pull request May 9, 2023
Merged
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
@aojea aojea mentioned this pull request Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

4 participants

@danwinship @k8s-ci-robot @aojea @wojtek-t