Skip to content

Conversation

@BenjaminBraunDev
Copy link
Contributor

This is stage 1 of 3 for adding in the latency prediction functionality to EPP.

Adds a new directory for the latency prediction and training sidecars for upcoming experimental latency prediction and SLO based routing scheduling profiles. Full details in issue below.

This does not change nor add any functionality as is, only introduces the sidecar module directory to be used to build the training and prediction images. These will later be deployed as containers alongside the EPP image.

Fixes #1323

Does this PR introduce a user-facing change?:

NONE 
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenjaminBraunDev
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BenjaminBraunDev. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2025
@BenjaminBraunDev BenjaminBraunDev changed the title Add latency predictor sidecars and epp tools [SLO Routing] Add Latency Predictor sidecars and EPP tools Oct 30, 2025
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e711de7
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/690a8e7859cca00009e35a67
😎 Deploy Preview https://deploy-preview-1791--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kfswain
Copy link
Collaborator

kfswain commented Oct 31, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2025
Copy link
Collaborator

@kfswain kfswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made another pass!

I think most importantly, we need to remove the binary files unless there is a good reason to check them in.

Otherwise left some smaller comments, and it's looking good.

…t dependencies, and unnecessary read lock, fix gitignore to ignore pycache again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

3 participants