- Notifications
You must be signed in to change notification settings - Fork 187
[SLO Routing] Add Latency Predictor sidecars and EPP tools #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[SLO Routing] Add Latency Predictor sidecars and EPP tools #1791
Conversation
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenjaminBraunDev The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files: Approvers can indicate their approval by writing |
| Hi @BenjaminBraunDev. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| /ok-to-test |
…causes a race condition error during unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made another pass!
I think most importantly, we need to remove the binary files unless there is a good reason to check them in.
Otherwise left some smaller comments, and it's looking good.
latencypredictor/__pycache__/test_dual_server_client.cpython-312-pytest-8.4.1.pyc Outdated Show resolved Hide resolved
…t dependencies, and unnecessary read lock, fix gitignore to ignore pycache again
This is stage 1 of 3 for adding in the latency prediction functionality to EPP.
Adds a new directory for the latency prediction and training sidecars for upcoming experimental latency prediction and SLO based routing scheduling profiles. Full details in issue below.
This does not change nor add any functionality as is, only introduces the sidecar module directory to be used to build the training and prediction images. These will later be deployed as containers alongside the EPP image.
Fixes #1323
Does this PR introduce a user-facing change?: