Backport: PR #1723 #1725
Merged
Backport: PR #1723 #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
k8s-ci-robot added kind/bug k8s-ci-robot added approved 
| /lgtm |
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--- FAIL: TestPickWeightedRandomPicker (0.28s) --- FAIL: TestPickWeightedRandomPicker/Multi-tier_weighted_test_-_A-Res_complex_distribution (0.05s) picker_test.go:248: Pod pod1: expected 0.345, got 0.329 (count: 329/1000) ✓ picker_test.go:248: Pod pod2: expected 0.310, got 0.309 (count: 309/1000) ✓ picker_test.go:248: Pod pod3: expected 0.172, got 0.171 (count: 171/1000) ✓ picker_test.go:248: Pod pod4: expected 0.103, got 0.105 (count: 105/1000) ✓ picker_test.go:245: Pod pod5: expected probability 0.069 ±20.0%, got 0.086 (count: 86/1000) FAIL coverage: 50.6% of statements FAIL sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/framework/plugins/picker 0.417s/retest |
--- FAIL: TestFlowRegistry_GarbageCollection_IdleFlows (0.01s) --- FAIL: TestFlowRegistry_GarbageCollection_IdleFlows/ShouldNotCollectFlow_WhenActivityRacesWithGC (0.09s) registry_test.go:605: Error Trace: /home/prow/go/src/sigs.k8s.io/gateway-api-inference-extension/pkg/epp/flowcontrol/registry/registry_test.go:185 /home/prow/go/src/sigs.k8s.io/gateway-api-inference-extension/pkg/epp/flowcontrol/registry/registry_test.go:605 Error: Received unexpected error: failed to get managed queue for flow "gc-flow:10": flow instance not found Test: TestFlowRegistry_GarbageCollection_IdleFlows/ShouldNotCollectFlow_WhenActivityRacesWithGC Messages: Flow should survive GC due to the 'Trust but Verify' live check FAIL coverage: 97.2% of statements FAIL sigs.k8s.io/gateway-api-inference-extension/pkg/epp/flowcontrol/registry 0.516sRetesting since this is a different error that ^ and should be unrelated to this PR. |
| /retest |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backports PR #1723, which adds the
PATCHenv var to the release script tooling.What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: