Skip to content

Conversation

@dongjiang1989
Copy link
Contributor

  1. Update golangci-lint latest version
  2. Add modernize lint
  3. Replace interface{} to any
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dongjiang1989 / name: dongjiang (c01736f)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dongjiang1989
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2025
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

text: 'SA1019: .*The component config package has been deprecated and will be removed in a future release.'
- linters:
- staticcheck
text: 'SA1019: .* is deprecated: .* is deprecated, use .* instead '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we disable the deprecation warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alvaroaleman
Some deprecated functions were found. I think we can fix them in the next PR.

pkg/builder/webhook.go:42:28: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck)	customDefaulter admission.CustomDefaulter ^ pkg/builder/webhook.go:45:28: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck)	customValidator admission.CustomValidator ^ pkg/builder/webhook.go:311:7: SA1019: admission.WithCustomValidator is deprecated: WithCustomValidator is deprecated, use WithValidator instead (staticcheck)	w = admission.WithCustomValidator(blder.mgr.GetScheme(), blder.apiType, blder.customValidator) ^ pkg/builder/webhook_test.go:1183:7: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck) var _ admission.CustomDefaulter = &TestCustomDefaulter{} ^ pkg/builder/webhook_test.go:1266:7: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck) var _ admission.CustomValidator = &TestCustomValidator{} ^ pkg/builder/webhook_test.go:1289:7: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck) var _ admission.CustomDefaulter = &TestCustomDefaulter{} ^ pkg/builder/webhook_test.go:1348:7: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck) var _ admission.CustomValidator = &TestCustomValidator{} ^ pkg/webhook/alias.go:29:24: SA1019: admission.CustomDefaulter is deprecated: CustomDefaulter is deprecated, use Defaulter instead (staticcheck) type CustomDefaulter = admission.CustomDefaulter ^ pkg/webhook/alias.go:34:24: SA1019: admission.CustomValidator is deprecated: CustomValidator is deprecated, use Validator instead (staticcheck) type CustomValidator = admission.CustomValidator ^ 9 issues: * staticcheck: 9 
Copy link
Member

@sbueringer sbueringer Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use local nolint comments for these cases. We just deprecated CustomDefaulter/CustomValidator we cannot remove them that quickly

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 17, 2025
@dongjiang1989
Copy link
Contributor Author

/test pull-controller-runtime-test

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 17, 2025
@k8s-ci-robot k8s-ci-robot removed the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2025
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

4 participants