Skip to content

🐛 Fix ginkgo panic in webhook integration test #3288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

🐛 Fix ginkgo panic in webhook integration test #3288

merged 1 commit into from
Aug 18, 2025

Conversation

@sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

Fixes https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-controller-runtime-test/1956593964882595840

Expect(err).NotTo(HaveOccurred())	/home/prow/go/src/github.com/kubernetes-sigs/controller-runtime/pkg/webhook/webhook_integration_test.go:115 When you, or your assertion library, calls Ginkgo's Fail(), Ginkgo panics to prevent subsequent assertions from running. Normally Ginkgo rescues this panic so you shouldn't see it.
@sbueringer
Fix ginkgo panic in webhook integration test
d063689 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/assign @alvaroaleman
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e283f594938d7fc2d913dbef1179b170470fb270
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot merged commit 8deb602 into kubernetes-sigs:main Aug 18, 2025
11 checks passed
@sbueringer sbueringer deleted the pr-fix-panic-webhook branch August 18, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

3 participants

@sbueringer @k8s-ci-robot @alvaroaleman