⚠ Fakeclient: Set ResourceVersion when adding objects to the tracker #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently an object that is added to the tracker will not have a ResourceVersion set. This can lead to tests that should fail with an IsConflict error succeeding when: * The object is added to the tracker * The object allows UnconditionalUpdate, i.E. Update with an empty ResourceVersion that will never conflict * The code under test retrieves such an object and then does an Update for it As this change results in different ResourceVersions for tests it is breaking.
k8s-ci-robot added the cncf-cla: yes k8s-ci-robot added approved 
| /approve |
k8s-ci-robot added the lgtm 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 9, 2021
Closed
This was referenced Mar 15, 2021
Closed
elmiko added a commit to elmiko/machine-api-operator that referenced this pull request Apr 14, 2021
This change adds a few fixes to the tests that are using the fake client, in specific these changes are related to this controller runtime change[0]. [0] kubernetes-sigs/controller-runtime#1306
elmiko added a commit to elmiko/machine-api-operator that referenced this pull request Apr 14, 2021
This change adds a few fixes to the tests that are using the fake client, in specific these changes are related to this controller runtime change[0]. [0] kubernetes-sigs/controller-runtime#1306
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this pull request Apr 19, 2021
The fake client stores the objects after adding a resource version to them. This is a breaking change introduced in kubernetes-sigs/controller-runtime#1306. Therefore we cannot use the fake object that we provided as input to the the fake client and should use the object obtained from the Get operation. The helper function returns the objects after obtaining them from the fake client and therefore these objects cannot be used for create functions. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2uasimojo added a commit to 2uasimojo/hive that referenced this pull request Jun 8, 2021
TL;DR: When comparing objects coming back from kube, things like ResourceVersion should be ignored (unless asserting that the object has not changed on the server, in which case comparing *only* ResourceVersion should suffice). We had a couple of tests that were using DeepEquals to compare an object from the (fake) kube server to one we constructed locally. The ResourceVersion returned by the fake server [changed in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306) which broke tests. We [worked around](openshift@c7d6052) that; but the Right Thing To Do™ is to make the comparison ignore ResourceVersion entirely. It is thusly done via this commit.
2uasimojo added a commit to 2uasimojo/hive that referenced this pull request Jun 8, 2021
TL;DR: When comparing objects coming back from kube, things like ResourceVersion should be ignored (unless asserting that the object has not changed on the server, in which case comparing *only* ResourceVersion should suffice). We had a couple of tests that were using DeepEquals to compare an object from the (fake) kube server to one we constructed locally. The ResourceVersion returned by the fake server [changed in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306) which broke tests. We [worked around](openshift@c7d6052) that; but the Right Thing To Do™ is to make the comparison ignore ResourceVersion entirely. It is thusly done via this commit.
2uasimojo added a commit to 2uasimojo/hive that referenced this pull request Jun 9, 2021
TL;DR: When comparing objects coming back from kube, things like ResourceVersion should be ignored (unless asserting that the object has not changed on the server, in which case comparing *only* ResourceVersion should suffice). We had a couple of tests that were using DeepEquals to compare an object from the (fake) kube server to one we constructed locally. The ResourceVersion returned by the fake server [changed in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306) which broke tests. We [worked around](openshift@c7d6052) that; but the Right Thing To Do™ is to make the comparison ignore ResourceVersion entirely. It is thusly done via this commit.
2uasimojo added a commit to 2uasimojo/hive that referenced this pull request Jun 9, 2021
This is a partial revert of c7d6052, which worked around a [breaking change in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306). A subsequent commit will fix the tests to disregard ResourceVersion.
2uasimojo added a commit to 2uasimojo/hive that referenced this pull request Jun 10, 2021
This is a partial revert of c7d6052, which worked around a [breaking change in controller-runtime 0.8.0](kubernetes-sigs/controller-runtime#1306). A subsequent commit will fix the tests to disregard ResourceVersion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently an object that is added to the tracker will not have a
ResourceVersion set. This can lead to tests that should fail with an
IsConflict error succeeding when:
ResourceVersion that will never conflict
for it
As this change results in different ResourceVersions for tests it is
breaking.