- Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Description
We would like to request that the Fake Client library be updated from the older gopkg.in/evanphx/json-patch.v4 to github.com/evanphx/json-patch/v5.
The primary motivation for this change is to remove the indirect dependency on github.com/pkg/errors that accompanies version v4. This indirect dependency was removed in json-patch v5.9.11 and has been integrated in controller-runtime since version v0.20.2.
Rationale
- Dependency Cleanup: Upgrading to v5 removes the indirect
github.com/pkg/errorsdependency, reducing the overall dependency footprint. - Upstream Compatibility: Aligning with newer releases ensures compatibility and support for future bug fixes and features.
- Consistency: As
controller-runtimeis already using newer versions, matching these library versions helps maintain consistency.
Proposal
- Update the import statement in
pkg/client/fake/client.gofromgopkg.in/evanphx/json-patch.v4togithub.com/evanphx/json-patch/v5. - Remove the direct
v4dependency entry fromgo.modin favor of thev5version, ensuring no regression in functionality. - Validate that existing tests pass and confirm there are no breaking changes.
Please let us know if you have any questions or need more details. Thank you for considering this request.
Metadata
Metadata
Assignees
Labels
No labels