- Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed as not planned
Closed as not planned
Copy link
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
controller-runtime register NewGoCollector() to export go runtime metrics, as https://github.com/kubernetes-sigs/controller-runtime/blob/67854429a3437a7684136c46fd8af1d33ea90de4/pkg/internal/controller/metrics/metrics.go#L84C14-L84C28.
However, prometheus/cient_golang incompatible upgrade leads original behavior breaks. Empty options args infunc NewGoCollector(opts ...func(o *internal.GoCollectorOptions)) will disable go_sche* metrics after v0.14.0, go_sche* is default enable before v.14.0.
We should provide options to user to configure what they want.
/kind feature
Metadata
Metadata
Assignees
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.