⚠️ Stop using FailureReason and FailureMessage in controllers #12148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added area/cluster k8s-ci-robot added the size/L 84 tasks
43 tasks
sbueringer reviewed May 7, 2025
fabriziopandini added the tide/merge-method-squash sbueringer reviewed May 8, 2025
docs/book/src/developer/providers/contracts/bootstrap-config.md Outdated Show resolved Hide resolved
Member
| I think #12148 (comment) and #12148 (comment) are still open + verify job is failing atm |
k8s-ci-robot added size/XL Member
| /lgtm /hold |
k8s-ci-robot added the do-not-merge/hold k8s-ci-robot added the lgtm 
Contributor
| LGTM label has been added. DetailsGit tree hash: de45857535c5775d7674ca6ad8ddcc6fd8c3b216 |
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved Member
| /hold cancel We'll address further findings in a follow-up if necessary |
k8s-ci-robot added needs-rebase fabriziopandini force-pushed the stop-using-failureReason-and-failureMessage branch from d985458 to 474a4d1 Compare k8s-ci-robot removed the lgtm k8s-ci-robot removed the needs-rebase Member
| /lgtm |
k8s-ci-robot added the lgtm Contributor
| LGTM label has been added. DetailsGit tree hash: 3ac0f5a1cac7147024350fb7784c5f84f14da5bb |
sbueringer force-pushed the stop-using-failureReason-and-failureMessage branch from 474a4d1 to 8dfbb39 Compare Member
| I force pushed the same commit again. I think tide was stuck somehow |
tylerauerbeck pushed a commit to tylerauerbeck/cluster-api that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As defined in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md, stop using FailureReason and FailureMessage in controllers
Which issue(s) this PR fixes:
Rif #11947
/area cluster
/area machine