- Notifications
You must be signed in to change notification settings - Fork 1.4k
⚠️ Bump to controller-runtime v0.20 & controller-tools v0.17 #11633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acde1a9 to 36d05a5 Compare 36d05a5 to e39ced6 Compare ded4c15 to e3c4303 Compare c0ac89b to 5fa1586 Compare | Tests will be green with the final CR release that will contain: kubernetes-sigs/controller-runtime#3074 |
5fa1586 to ed0625b Compare 957b429 to c01ebd4 Compare | /test pull-cluster-api-e2e-main |
| @sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| /test pull-cluster-api-e2e-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| LGTM label has been added. Git tree hash: dd4767644f859cc1424b3f554d204bbf9982cd0c |
| /hold Forgot to bump the cloudbuild image. Working on bumping the image to Go 1.23 in test-infra. Will add one commit in a bit (but feel free to review this PR already) |
| Lgtm, pending GCB :-) |
| /test pull-cluster-api-e2e-main /hold cancel ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
/lgtm
/approve
| LGTM label has been added. Git tree hash: af6c368cd03640858d3d13d37d8030f7df079590 |
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Contains:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11064
Related kubernetes/test-infra#34157